You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a clean TypeScript migration for the Cypress test suite. A couple of minor points worth addressing:
🔵 Minor
cypress/tsconfig.json does not cover cypress.config.ts
The "include": ["**/*.ts"] in cypress/tsconfig.json resolves to cypress/**/*.ts (relative to where the tsconfig lives). The root-level cypress.config.ts sits outside that directory and will not be type-checked by this config — nor by tsconfig.json (which only includes src/) or tsconfig.node.json (which only includes vite.config.ts).
Fix: add an explicit reference in cypress/tsconfig.json:
"include": ["**/*.ts", "../cypress.config.ts"]
"types": ["vitest/globals"] in tsconfig.node.json is unnecessary
The old /// <reference types="vitest" /> directive was needed to augment defineConfig from vite with Vitest's test options. Switching to import { defineConfig } from 'vitest/config' makes the directive redundant and already provides those config types directly through the import.
vitest/globals is a separate concern — it injects globals like describe, it, and expect into the environment, which are not needed in vite.config.ts. The addition is harmless but unnecessary noise in the node config.
Overall this is a solid, straightforward conversion with the declare global augmentation for custom commands and the centralised cypress/tsconfig.json being the right approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.