-
Notifications
You must be signed in to change notification settings - Fork 5
Vue based UI + Websocket-based remote editor support #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In my case, I just have terrible issues trying to install node 18.
The basic workflow is: 1. Open editor with companion extension. 2. Get the code from editor. 3. Open extension popup and paste the code. 4. Use connection to edit files. UX and UI needs work but the basic functionality and communication protocol should be good enough like this.
…rge_remote_editor_support
Add a Vue based UI
brunoais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just unsure about 3 things which may or may not be problems.
I didn't test the extension in firefox. I'll find time, somehow, to test it tomorrow.
brunoais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked with me and my extension. I could improve my extension but I'm still learning the API.
Just wanting for response to my comments at this point, @derjanb
| @@ -0,0 +1,226 @@ | |||
| // SIMPLE GRID - SASS/SCSS | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this better than using CSS' grid? if it is, what are the advantages of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily better, but something I've gotten used to. Its classes are based on bootstrap. At the moment only very basic layouting is done, but later a full bootstrap CSS could be used without changing the html code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. Way different work method than mine but your point makes sense for such workflow.
I'm just too used to not using frameworks for CSS and HTML and just use the APIs that are standard (and then an autoprefixer). So I'm not used to these stuff.
No description provided.