-
Notifications
You must be signed in to change notification settings - Fork 100
WIP: predicate pushdown to sync #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
81adfde
to
6125b7d
Compare
@kevin-dp I rebased this branch on main and fixed the conflicts where we have refactored the |
6125b7d
to
06df69f
Compare
This is close, we just need to implement config options. We had discussed two new modes for collections:
We then have the current mode where the collection loads the full snapshot and becomes "ready" when done. These new modes map to Electric collections well, but maybe less well to Query collections. I don't like this naming, and I also think we should consider splitting the config into multiple dimensions rather than combining them. I think the dimensions are:
The planned options did not cover the "lazy load the initial snapshot, mark ready immediately, but there is no incremental snapshots" as an option. This is useful for situations where you want to render a main collection immediately, but a joined one can come in later. (we talked about this being a mode of a join, but maybe its a mode of a collection?) We also need to decide what options apply to all collections, and what to specific collection types. |
95ea893
to
ec0e23f
Compare
3097cd8
to
617988c
Compare
No description provided.