Skip to content

fix: improve popup handling for non-vite environments #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlemTuzlak merged 2 commits into from
Jan 8, 2026
Merged

fix: improve popup handling for non-vite environments #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e5190f
fix: improve popup handling for non-vite environments
AlemTuzlak Jan 8, 2026
9768365
ci: apply automated fixes
autofix-ci[bot] Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ready-peas-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/devtools': patch
---

fix issue with popups in non-vite environments
13 changes: 7 additions & 6 deletions packages/devtools/src/context/pip-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,13 @@ export const PiPProvider = (props: PiPProviderProps) => {
'Failed to open popup. Please allow popups for this site to view the devtools in picture-in-picture mode.',
)
}
// can be run outside of vite so we ignore the rule
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
import.meta?.hot?.on('vite:beforeUpdate', () => {
localStorage.setItem('pip_open', 'false')
closePipWindow()
})

if (import.meta.hot && typeof import.meta.hot.on === 'function') {
import.meta.hot.on('vite:beforeUpdate', () => {
localStorage.setItem('pip_open', 'false')
closePipWindow()
})
}
window.addEventListener('beforeunload', () => {
localStorage.setItem('pip_open', 'false')
closePipWindow()
Expand Down
Loading