-
-
Notifications
You must be signed in to change notification settings - Fork 499
fix(form-core): Trigger listeners and validation on setFieldValue
#1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(form-core): Trigger listeners and validation on setFieldValue
#1680
Conversation
View your CI Pipeline Execution ↗ for commit 724f0a4
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
+ Coverage 90.49% 90.61% +0.12%
==========================================
Files 37 37
Lines 1683 1705 +22
Branches 421 435 +14
==========================================
+ Hits 1523 1545 +22
Misses 143 143
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I initially thought I should mark as draft to refactor how form listeners are currently set up. However, it appears that it would be a breaking change since So I suppose this is already done. |
setFieldValue
trigger listeners and validationsetFieldValue
trigger listeners and validation
setFieldValue
trigger listeners and validationsetFieldValue
Also adds two meta properties,
dontValidate
anddontRunListeners
. Should help in case someone wants extreme control, but it's more for our sake.