Skip to content

fix(core): fix formOptions type inferance #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

harry-whorlow
Copy link
Contributor

Relates to #1613, this pr introduces more tests to form options, as well as fixes the typing error.

Copy link

nx-cloud bot commented Aug 11, 2025

View your CI Pipeline Execution ↗ for commit eb9d5da

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 31s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-12 09:32:14 UTC

Copy link

pkg-pr-new bot commented Aug 11, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1687

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1687

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1687

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1687

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1687

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1687

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1687

commit: eb9d5da

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9e092e2). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1687   +/-   ##
=======================================
  Coverage        ?   90.52%           
=======================================
  Files           ?       37           
  Lines           ?     1688           
  Branches        ?      421           
=======================================
  Hits            ?     1528           
  Misses          ?      143           
  Partials        ?       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants