Skip to content

Conversation

fulopkovacs
Copy link
Contributor

🎯 Changes

The form composition API (React Large Form) was confusing, because an onChange validator was defined in the main form, not in the formOptions, which was misleading, because if you try to add async validators there, TypeScript will complain about the form passed down through the child form's props (see this StackBlitz box).

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Copy link

changeset-bot bot commented Sep 28, 2025

⚠️ No Changeset found

Latest commit: dee85ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Sep 28, 2025

View your CI Pipeline Execution ↗ for commit dee85ff

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 12s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-28 19:01:01 UTC

Copy link

pkg-pr-new bot commented Sep 28, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1777

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1777

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1777

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1777

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1777

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1777

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1777

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1777

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1777

commit: dee85ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant