Fix react compiler #1893
Merged
Fix react compiler #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3da6ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit a3da6ef
☁️ Nx Cloud last updated this comment at |
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
- Coverage 90.35% 90.12% -0.23%
==========================================
Files 38 41 +3
Lines 1752 1884 +132
Branches 444 473 +29
==========================================
+ Hits 1583 1698 +115
- Misses 149 166 +17
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TkDodo
reviewed
Dec 1, 2025
Member
Author
|
@TkDodo ready for re-review! Thanks for your help here |
Merged
mhornbacher
added a commit
to mhornbacher/tanstack-form
that referenced
this pull request
Dec 6, 2025
Attempts to resolve TanStack#1907 Removes `Math.random()` introduced in TanStack#1893 from the hot path allowing the page to be pre-built with a a user provided form id. source: https://nextjs.org/docs/app/getting-started/cache-components#non-deterministic-operations
mhornbacher
added a commit
to mhornbacher/tanstack-form
that referenced
this pull request
Dec 6, 2025
Attempts to resolve TanStack#1907 Removes `Math.random()` introduced in TanStack#1893 from the hot path allowing the page to be pre-built with a a user provided form id. source: https://nextjs.org/docs/app/getting-started/cache-components#non-deterministic-operations
4 tasks
crutchcorn
pushed a commit
that referenced
this pull request
Dec 7, 2025
* fix(react-form): fix cache components support Attempts to resolve #1907 Removes `Math.random()` introduced in #1893 from the hot path allowing the page to be pre-built with a a user provided form id. source: https://nextjs.org/docs/app/getting-started/cache-components#non-deterministic-operations * generate changeset * Change to patch * feat: use useId on React 18+ with a fallback to uuid on React 17 * chore: incredible review feedback * update changelog * chore: rename file * import correctly * return a stable UUID reference * chore: switch from useMemo to useState * ci: apply automated fixes and generate docs --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the React compiler where there were edgecases we'd hit previously.
Closes: #1832