Skip to content

Conversation

@Makisuo
Copy link
Contributor

@Makisuo Makisuo commented Aug 18, 2024

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Aug 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37379a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />

<title>TanStack Form React Valibot Example App</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<title>TanStack Form React Valibot Example App</title>
<title>TanStack Form React Arktype Example App</title>


return (
<div>
<h1>Valibot Form Example</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>Valibot Form Example</h1>
<h1>Arktype Form Example</h1>

"arktype": "2.0.0-beta.5",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"valibot": "^0.37.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "valibot" dependency should not be needed here

@Balastrong
Copy link
Member

Thank you everyone for the effort here!
The bad news is that I'm closing this PR, the good news is that after #1020 lands, arktype will be natively supported as it implements Standard Schema 🙌

@Balastrong Balastrong closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants