Skip to content

chore(deps): update dependency vite to v5 [security] #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore(deps): update dependency vite to v5 [security] #9708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/vue/2.6-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"typescript": "5.8.3",
"vite": "^4.5.14",
"vite": "^5.4.20",
"vite-plugin-vue2": "2.0.3"
Comment on lines 17 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Upgrade blocked by Vue 2.6 plugin compatibility

Line 17 moves this example to Vite ^5.4.20 while retaining [email protected], but that plugin’s peer constraint is vite ^2 || ^3, so installation will fail and the tooling won’t run.(npmpeer.dev) Compounding that, the package is in maintenance mode and only supports Vue 2.6 or earlier with no Vite 5-ready release, so we either keep this example on Vite 4 or migrate it to Vue 2.7 plus @vitejs/plugin-vue2 before bumping Vite.(npm.io)

🤖 Prompt for AI Agents 
In examples/vue/2.6-basic/package.json around lines 17-19, Vite was bumped to
^5.4.20 but the project still depends on [email protected] which only
supports vite ^2 || ^3 and is not Vite 5 compatible; fix by either (A) pinning
Vite to a Vite-4-compatible version (e.g., ^4.x) so the existing
vite-plugin-vue2 remains valid, or (B) migrate the example to Vue 2.7 and
replace vite-plugin-vue2 with a Vite-5-compatible plugin (e.g.,
@vitejs/plugin-vue2), update package.json and any plugin-related config/code,
then run npm install and smoke-test the dev/build to ensure tooling works.

Comment on lines +18 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Revert the Vite bump or migrate this example

[email protected] caps its vite peer at ^3. With vite set to ^5.4.20 the install fails and the dev build breaks. For this Vue 2.6 example either keep Vite at the previous ^4.x (or lower) or upgrade the example to Vue 2.7 plus @vitejs/plugin-vue2 before moving to Vite 7. As-is the dependency graph is unsatisfied and the example is unusable.

🤖 Prompt for AI Agents 
In examples/vue/2.6-basic/package.json around lines 18-19, the current vite
("^5.4.20") conflicts with [email protected] which has a Vite peer capped
at ^3, causing install/dev failures; fix by either reverting Vite to a
compatible range (e.g., set "vite" to the previous ^4.x or the exact version
previously used) and reinstall, or migrate the example to Vue 2.7 and replace
vite-plugin-vue2 with @vitejs/plugin-vue2 (update package.json, adjust any
plugin config code, run npm/yarn install and verify the dev build).

}
}
2 changes: 1 addition & 1 deletion examples/vue/2.7-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"devDependencies": {
"typescript": "5.8.3",
"vite": "^4.5.14",
"vite": "^5.4.20",
"vite-plugin-vue2": "2.0.3"
}
Comment on lines +17 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix Vite/plugin compatibility blocker

[email protected] only peers with vite ^2 || ^3, so bumping Vite to ^5.4.20 (let alone the PR’s V7 goal) will cause an install-time ERESOLVE and the example can’t run. Swap to the maintained @vitejs/plugin-vue2 at a release whose peer range covers Vite 7, and bump Vite to the intended ^7.1.9 so the security fix lands. Remember to update the Vite config to import/use the new plugin.

-    "vite": "^5.4.20",
-    "vite-plugin-vue2": "2.0.3"
+    "vite": "^7.1.9",
+    "@vitejs/plugin-vue2": "^2.4.0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"vite": "^5.4.20",
"vite-plugin-vue2": "2.0.3"
}
{
// …
- "vite": "^5.4.20",
"vite": "^7.1.9",
"@vitejs/plugin-vue2": "^2.4.0"
}

}
Loading