docs:(start): add start mcp example #4837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit b305cbf
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
| "scripts": { | ||
| "dev": "vite dev", | ||
| "build": "vite build && tsc --noEmit", | ||
| "start": "vite start" |
There was a problem hiding this comment.
vite start wont work I guess?
There was a problem hiding this comment.
I copied from the start-counter example but I haven't tried before. I did now and... yeah vite start doesn't seem to work.
Should we replace all vite start with node .output/server/index.mjs in the examples?
There was a problem hiding this comment.
well it depends on the deployment target. by default, it's using node, so yes it would work. if someone changes to e.g. bun, the start command would need to be different ...
There was a problem hiding this comment.
Is it something related to this PR (adding the new mcp example) only or is it a global decision for all start commands in all examples/docs?
I'd say as long as we explain in the docs how to run in all environments should be fine that we show one in the feature-related examples
| export async function handleMcpRequest(request: Request, server: McpServer) { | ||
| const body = await request.json() | ||
| const event = getEvent() | ||
| const res = event.node.res |
There was a problem hiding this comment.
this will only work in node then.... how about other runtimes?
There was a problem hiding this comment.
With Bun looks like it's working. After all it's the official mcp sdk having a hard dependency on that, I don't think we can be much more flexible until they open their implementation a bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A working example integrating the official
@modelcontextprotocol/sdkto create a stateless http server on a start route.The server is exposed on
http://localhost:3000/apiand has a resource (tells the counter value, from the counter example) and a tool (sums two numbers).