fix(history): add ignoreBlocker support to go method (#4867) #4872
+101
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes GitHub issue #4867 -
history.go
does not respectignoreBlocker
option.Currently, when using TanStack Router with
BrowserHistory
, theignoreBlocker
option works as expected forhistory.back
andhistory.forward
, but does not work forhistory.go
. This means that navigation blockers are still triggered even whenignoreBlocker: true
is passed tohistory.go
.Changes
Core Fix
packages/history/src/index.ts
:ignoreBlocker
parameter togo
method increateBrowserHistory
createHistory
to passignoreBlocker
to underlyinggo
implementationback
,forward
, andgo
methodsTesting
packages/history/tests/ignoreBlocker.test.ts
:back
,forward
,go
) withignoreBlocker
option increateBrowserHistory