Skip to content

fix: optimizeDeps for react-form-start #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −6
Open

fix: optimizeDeps for react-form-start #5926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61db78a
fix: optimizeDeps for react-form-start
eve0415 Nov 20, 2025
a27bfbf
ci: apply automated fixes
autofix-ci[bot] Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions e2e/solid-start/basic-cloudflare/worker-configuration.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,19 @@
// Generated by Wrangler by running `wrangler types` (hash: b11df627d8b3c51b1bf3230a546b0f20)
// Runtime types generated with [email protected] 2025-09-24 nodejs_compat
declare namespace Cloudflare {
interface Env {
MY_VAR: "Hello from Cloudflare";
}
interface Env {
MY_VAR: 'Hello from Cloudflare'
}
}
interface Env extends Cloudflare.Env {}
type StringifyValues<EnvType extends Record<string, unknown>> = {
[Binding in keyof EnvType]: EnvType[Binding] extends string ? EnvType[Binding] : string;
};
[Binding in keyof EnvType]: EnvType[Binding] extends string
? EnvType[Binding]
: string
}
declare namespace NodeJS {
interface ProcessEnv extends StringifyValues<Pick<Cloudflare.Env, "MY_VAR">> {}
interface ProcessEnv
extends StringifyValues<Pick<Cloudflare.Env, 'MY_VAR'>> {}
}

// Begin runtime types
Expand Down
5 changes: 5 additions & 0 deletions packages/react-start/src/plugin/vite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ export function tanstackStart(
)
? ['@tanstack/react-form > @tanstack/react-store']
: []),
...(options.optimizeDeps?.exclude?.find(
(x) => x === '@tanstack/react-form-start',
)
? ['@tanstack/react-form-start > @tanstack/react-store']
: []),
],
}
: undefined,
Expand Down