Skip to content

fix: prerendering with docker build #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edmundhung wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix: prerendering with docker build #6305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/start-plugin-core/src/prerender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ async function startPreviewServer(
return await vite.preview({
configFile: viteConfig.configFile,
preview: {
host: '127.0.0.1',
Copy link
Member

@SeanCassiere SeanCassiere Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make the host configurable for the prerenderer, since there are instances where people might want to set it to 0.0.0.0 as well.

Copy link
Contributor Author

@edmundhung edmundhung Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users can already control the host via the preview server config as I mentioned in the original issue. I wonder if it would be simpler to rely on the existing setting and document how it affects prerendering, instead of introducing a prerender-specific option here.

Copy link
Contributor

@schiller-manuel schiller-manuel Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes instead of hard coding here, we should document this, especially for the common docker case.

port: 0,
open: false,
},
Expand Down
Loading