PoC(solid-router): full-document hydration #6318
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
documentation
|
View your CI Pipeline Execution ↗ for commit 629c4d5 ☁️ Nx Cloud last updated this comment at |
birkskyum
changed the title
<head>
|
I'm pretty sure we already did full document hydration. Maybe the docs just weren't updated? |
| const router = createRouter() | ||
|
|
||
| hydrate(() => <RouterClient router={router} />, document.body) | ||
| hydrate(() => <RouterClient router={router} />, document) |
There was a problem hiding this comment.
didn't we have a hydrateStart function or did that change?
| return ( | ||
| <html> | ||
| <head> | ||
| <HydrationScript /> |
There was a problem hiding this comment.
don't we still need the HydrationScript?
| hydrationPromise = Promise.resolve() | ||
| } | ||
| } | ||
| return ( |
There was a problem hiding this comment.
I feel like i changed this all. Is this an oudated file?
This hydrates document instead of document.body
Also move HeadContent to
<head>Depends on