Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-carrots-listen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/store': patch
---

refactor(store): replace array with set in \_\_depsThatHaveWrittenThisTick
2 changes: 1 addition & 1 deletion docs/reference/variables/depsThatHaveWrittenThisTick.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ Defined in: [scheduler.ts:28](https://github.com/TanStack/store/blob/main/packag
```ts
current: (
| Derived<unknown, readonly any[]>
| Store<unknown, (cb) => unknown>)[];
| Set<Store<unknown, (cb: unknown) => unknown>)[];
```
10 changes: 5 additions & 5 deletions packages/store/src/scheduler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const __derivedToStore = new WeakMap<
>()

export const __depsThatHaveWrittenThisTick = {
current: [] as Array<Derived<unknown> | Store<unknown>>,
current: new Set<Derived<unknown> | Store<unknown>>(),
}

let __isFlushing = false
Expand All @@ -37,11 +37,11 @@ const __initialBatchValues = new Map<Store<unknown>, unknown>()

function __flush_internals(relatedVals: ReadonlyArray<Derived<unknown>>) {
for (const derived of relatedVals) {
if (__depsThatHaveWrittenThisTick.current.includes(derived)) {
if (__depsThatHaveWrittenThisTick.current.has(derived)) {
continue
}

__depsThatHaveWrittenThisTick.current.push(derived)
__depsThatHaveWrittenThisTick.current.add(derived)
derived.recompute()

const stores = __derivedToStore.get(derived)
Expand Down Expand Up @@ -109,7 +109,7 @@ export function __flush(store: Store<unknown>) {
const derivedVals = __storeToDerived.get(store)
if (!derivedVals) continue

__depsThatHaveWrittenThisTick.current.push(store)
__depsThatHaveWrittenThisTick.current.add(store)
__flush_internals(derivedVals)
}

Expand All @@ -125,7 +125,7 @@ export function __flush(store: Store<unknown>) {
}
} finally {
__isFlushing = false
__depsThatHaveWrittenThisTick.current = []
__depsThatHaveWrittenThisTick.current.clear()
__initialBatchValues.clear()
}
}
Expand Down