fix tests, cleanup code

Author: riccardoperra

packages/angular-table/src/flex-render.ts

@@ -73,13 +73,13 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
   ) {}
 
   ngOnChanges(changes: SimpleChanges) {
-    if (changes['content']) {
-      this.renderFlags |= FlexRenderFlags.ContentChanged
-    }
     if (changes['props']) {
       this.renderFlags |= FlexRenderFlags.PropsReferenceChanged
     }
-    this.checkView()
+    if (changes['content']) {
+      this.renderFlags |= FlexRenderFlags.ContentChanged
+      this.checkView()
+    }
   }
 
   ngDoCheck(): void {
@@ -90,25 +90,18 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
       return
     }
 
-    if (
-      this.renderFlags &
-      (FlexRenderFlags.PropsReferenceChanged | FlexRenderFlags.ContentChanged)
-    ) {
-      return
-    }
-
     const contentToRender = this.#getContentValue(this.props)
 
     if (contentToRender.kind === 'null' || !this.renderView) {
       this.renderFlags |= FlexRenderFlags.Creation
     } else {
       this.renderView.setContent(contentToRender.content)
-      const previousContentInfo = this.renderView.previousContent
+      this.renderFlags |= FlexRenderFlags.DirtyCheck
 
-      this.renderFlags |=
-        contentToRender.kind === previousContentInfo.kind
-          ? FlexRenderFlags.DirtyCheck
-          : FlexRenderFlags.ContentChanged
+      const previousContentInfo = this.renderView.previousContent
+      if (contentToRender.kind !== previousContentInfo.kind) {
+        this.renderFlags |= FlexRenderFlags.ContentChanged
+      }
     }
 
     this.checkView()
@@ -126,12 +119,11 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
     if (this.renderFlags & FlexRenderFlags.PropsReferenceChanged) {
       if (this.renderView) this.renderView.updateProps(this.props)
       this.renderFlags &= ~FlexRenderFlags.PropsReferenceChanged
-      return
     }
 
     if (this.renderFlags & FlexRenderFlags.DirtyCheck) {
       if (this.renderView) this.renderView.dirtyCheck()
-      this.renderFlags &= ~FlexRenderFlags.DirtyCheck
+      this.renderFlags = FlexRenderFlags.Pristine
     }
   }
 
@@ -143,9 +135,7 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
       return
     }
     this.renderView = this.#renderViewByContent(resolvedContent)
-    this.renderFlags &= ~(
-      FlexRenderFlags.ContentChanged | FlexRenderFlags.PropsReferenceChanged
-    )
+    this.renderFlags = FlexRenderFlags.Pristine
   }
 
   #renderViewByContent(

packages/angular-table/src/flex-render/flags.ts

@@ -3,21 +3,25 @@ export enum FlexRenderFlags {
    * Whether the view has not been created yet or the current view will be cleared during the update phase.
    */
   Creation = 1 << 0,
+  /**
+   * Whether the view is not dirty.
+   */
+  Pristine = 1 << 1,
   /**
    * Indicates that the `content` property has changed or the view need a complete re-rendering.
    * When this flag is enabled, the view is recreated from scratch after clearing the previous one.
    */
-  ContentChanged = 1 << 1,
+  ContentChanged = 1 << 2,
   /**
    * Indicates that the `props` property reference has changed.
    * When this flag is enabled, the view context is updated based on the type of the content.
    *
    * For Component view, inputs will be updated and view will be marked as dirty.
    * For TemplateRef and primitive values, view will be marked as dirty
    */
-  PropsReferenceChanged = 1 << 2,
+  PropsReferenceChanged = 1 << 3,
   /**
    * Indicates the current rendered view has to be dirty checked.
    */
-  DirtyCheck = 1 << 3,
+  DirtyCheck = 1 << 4,
 }

packages/angular-table/src/flex-render/view.ts

@@ -125,6 +125,7 @@ export class FlexRenderComponentView extends FlexRenderView<
         if (this.view.eqType(this.content.content)) {
           this.view.update(this.content.content)
         }
+        this.view.markAsDirty()
         break
       }
     }

packages/angular-table/tests/flex-render.test.ts

@@ -138,11 +138,7 @@ describe('FlexRenderDirective', () => {
     class FakeComponent {
       row = input.required<{ property: string }>()
 
-      constructor() {
-        effect(() => {
-          console.log('row', this.row())
-        })
-      }
+      constructor() {}
     }
 
     const fixture = TestBed.createComponent(TestRenderComponent)