refactor: fixes and moves all tests in core to new structure #5841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-short
commented
Dec 21, 2024
will-short
commented
- moves all tests in core package to new structure
- removes old helpers
- adds TODO's in existing tests to get them to use new helpers
- fixes up all existing tests to pass
|
View your CI Pipeline Execution ↗ for commit e3e946c.
☁️ Nx Cloud last updated this comment at |
will-short
commented
Dec 21, 2024
| @@ -37,7 +38,6 @@ describe('constructTable', () => { | |||
| expect(table).toHaveProperty('getRow') | |||
|
|
|||
| // table APIs | |||
| expect(table).toHaveProperty('_queue') | |||
Author
There was a problem hiding this comment.
@KevinVandy seems like _queue was removed. just wanted to flag this to make sure I saw that correctly
Member
There was a problem hiding this comment.
yeah, a couple of apis were removed
KevinVandy
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.