fix: renderComponent, add renderSnippet, and some other Svelte fix-ups
#5888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 65aab40.
☁️ Nx Cloud last updated this comment at |
walker-tx
changed the title
renderComponent, add renderSnippet, and some other Svelte fix-upsrenderComponent, add renderSnippet, and some other Svelte fix-ups
KevinVandy
reviewed
Jan 26, 2025
| {#snippet mailtoLink(email: string)} | ||
| <a href="mailto:{email}"> | ||
| {email} | ||
| </span> |
KevinVandy
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes a few things for the Svelte adapter:
renderComponentrenderComponents)renderSnippetnow allows users to render snippets (markup or programatic)renderSnippetrenderSnippet, and added it to a code example