Skip to content

Conversation

Safy98
Copy link

@Safy98 Safy98 commented Sep 30, 2025

🎯 Changes

fixed a typo where the 'both' word is written twice in this paragraph :

TanStack table supports both both client-side and manual server-side filtering. This guide will go over how to implement and customize both, and help you decide which one is best for your use-case.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Documentation
    • Corrected a typographical redundancy in the column filtering guide to improve readability.
    • Adjusted formatting in the API section for clearer presentation.
    • No changes to filtering behavior or public API.

fixed a typo where the 'both' word is written twice
Copy link

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: 82c7c2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Sep 30, 2025

Walkthrough

Documentation typo and minor formatting fix in docs/guide/column-filtering.md; no API or behavioral changes.

Changes

Cohort / File(s) Summary
Docs: Typo and formatting
docs/guide/column-filtering.md
Corrected redundant phrase to “client-side” and adjusted formatting around the “column.getFilterFn” bullet without semantic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A nibble of text, a hop through a line,
I trimmed a repeat so the doc looks fine.
No filters were changed, no APIs stirred—
Just cleaner carrots in the garden of words.
Thump-thump! Onward to clarity, dear herd.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “Update column-filtering.md” accurately identifies the file changed but is overly generic and does not specify the actual change (a typo fix) performed in the documentation. Consider revising the title to clearly convey the change’s intent, for example “Fix duplicated word typo in column-filtering.md” so that it immediately communicates the specific update made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The pull request description follows the repository’s template by detailing the typo fix under “🎯 Changes,” including the contributor checklist, and correctly marking the release impact as a docs‐only change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02c203a and 82c7c2e.

📒 Files selected for processing (1)
  • docs/guide/column-filtering.md (2 hunks)
🔇 Additional comments (1)
docs/guide/column-filtering.md (1)

26-26: LGTM! Typo fix improves readability.

The duplicate "both" has been correctly removed, making the sentence read properly.

Comment on lines 333 to 335
- `column.getAutoFilterFn` -
- `column.getFilterFn` - Useful for displaying which filter mode or function is currently being used
- `column.getFilterFn` - Useful for displaying which filter mode or function is currently being used
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Incomplete documentation for column.getAutoFilterFn.

Line 334 has an incomplete bullet point - the description for column.getAutoFilterFn is missing. Please add a description similar to the other API entries.

For example:

-- `column.getAutoFilterFn` - 
+- `column.getAutoFilterFn` - Useful for retrieving the automatically determined filter function for the column
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- `column.getAutoFilterFn` -
- `column.getFilterFn` - Useful for displaying which filter mode or function is currently being used
\ No newline at end of file
- `column.getFilterFn` - Useful for displaying which filter mode or function is currently being used
- `column.getAutoFilterFn` - Useful for retrieving the automatically determined filter function for the column
- `column.getFilterFn` - Useful for displaying which filter mode or function is currently being used
🤖 Prompt for AI Agents
In docs/guide/column-filtering.md around lines 334 to 335, the bullet for
`column.getAutoFilterFn` is incomplete; add a concise description similar to the
adjacent entry. Update the line to explain that `column.getAutoFilterFn` returns
the automatically resolved filter function for the column (used to determine the
default or inferred filter behavior), so consumers can see which auto-selected
filter is in effect; keep wording consistent with the `column.getFilterFn`
entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant