Skip to content

[BUG] ignore non expandable rows when the expanded state changes #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RichardHpa wants to merge 5 commits into
base: main
Choose a base branch
from
+11 −5
Open

[BUG] ignore non expandable rows when the expanded state changes #6116

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5f80b7
dont include rows that arent expandable
RichardHpa Oct 21, 2025
dc6cc2a
reverted return statement
RichardHpa Oct 21, 2025
35541e2
added changeset
RichardHpa Oct 21, 2025
9f7b468
Merge branch 'main' into fix/ignore-non-expandable-rows
RichardHpa Dec 10, 2025
6ad1c88
updated changelog comment
RichardHpa Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/every-parks-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/table-core': patch
---

Prevents non expandable rows from being added to the state when the old state was true
11 changes: 6 additions & 5 deletions packages/table-core/src/features/RowExpanding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,7 @@ export const RowExpanding: TableFeature = {
}
}
table.resetExpanded = (defaultState) => {
table.setExpanded(
defaultState ? {} : (table.initialState?.expanded ?? {}),
)
table.setExpanded(defaultState ? {} : table.initialState?.expanded ?? {})
}
table.getCanSomeRowsExpand = () => {
return table
Expand Down Expand Up @@ -296,8 +294,11 @@ export const RowExpanding: TableFeature = {
let oldExpanded: ExpandedStateList = {}

if (old === true) {
Object.keys(table.getRowModel().rowsById).forEach((rowId) => {
oldExpanded[rowId] = true
const rowIds = table.getRowModel().rowsById
Object.keys(rowIds).forEach((rowId) => {
if (rowIds[rowId]?.getCanExpand()) {
oldExpanded[rowId] = true
}
})
} else {
oldExpanded = old
Expand Down