Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
"changelog": [
"@svitejs/changesets-changelog-github-compact",
{ "repo": "TanStack/table" }
],
"commit": false,
"access": "public",
"baseBranch": "alpha",
"updateInternalDependencies": "patch",
"fixed": [],
"linked": [],
"ignore": [],
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"onlyUpdatePeerDependentsWhenOutOfRange": true
}
}
22 changes: 9 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
name: ci

on:
workflow_dispatch:
inputs:
tag:
description: override release tag
required: false
push:
branches: [main, alpha, beta, rc]

Expand All @@ -19,6 +14,7 @@ env:
permissions:
contents: write
id-token: write
pull-requests: write

jobs:
test-and-publish:
Expand All @@ -39,13 +35,13 @@ jobs:
- name: Stop Nx Agents
if: ${{ always() }}
run: npx nx-cloud stop-all-agents
- name: Publish
run: |
git config --global user.name 'Tanner Linsley'
git config --global user.email '[email protected]'
npm config set '//registry.npmjs.org/:_authToken' "${NPM_TOKEN}"
pnpm run cipublish
- name: Run Changesets (version or publish)
uses: changesets/[email protected]
with:
version: pnpm run changeset:version
publish: pnpm run changeset:publish
commit: 'ci: Version Packages'
title: 'ci: Version Packages'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
TAG: ${{ inputs.tag }}
20 changes: 10 additions & 10 deletions examples/angular/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@
},
"private": true,
"dependencies": {
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/router": "^21.0.6",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@angular/router": "^21.0.8",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"@types/jasmine": "~5.1.13",
"jasmine-core": "~5.13.0",
"tslib": "^2.8.1",
Expand Down
18 changes: 9 additions & 9 deletions examples/angular/column-ordering/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@
},
"private": true,
"dependencies": {
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"tslib": "^2.8.1",
"typescript": "5.9.3"
}
Comment on lines 13 to 30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Scanning Angular example package.json files for Angular version skew and build tooling..."

fd -a -t f package.json examples/angular | while read -r f; do
  python - <<'PY' "$f"
import json, sys
p = sys.argv[1]
d = json.load(open(p))
deps = d.get("dependencies", {})
dev = d.get("devDependencies", {})
def pick(m, k): return m.get(k)
angular = {k:v for k,v in {**deps, **dev}.items() if k.startswith("@angular/")}
build = pick(dev, "@angular/build")
devkit = pick(dev, "@angular-devkit/build-angular")
if angular or build or devkit:
  vers = {k:angular[k] for k in sorted(angular)}
  print(p)
  if vers:
    # highlight potentially mixed patch levels
    patches = sorted(set(vers.values()))
    print("  @angular/* versions:", patches)
  if build: print("  uses @angular/build:", build)
  if devkit: print("  uses @angular-devkit/build-angular:", devkit)
PY
done

Repository: TanStack/table

Length of output: 2487


Resolve Angular version and build-tooling inconsistencies across examples.

The patch-version skew you flagged is confirmed: all 16 Angular examples mix ^21.0.5 and ^21.0.8 across their @angular/* dependencies. Additionally, a build-tooling split existsβ€”most examples use @angular/build: ^21.0.5, but 6 examples (column-resizing-performant, editable, expanding, remote-data, row-dnd, sub-components) use @angular-devkit/build-angular: ^21.0.5 instead. The row-dnd example also contains an outlier at ^21.0.6. Standardize versions and build tooling across all Angular examples to prevent maintenance drift and compatibility issues.

πŸ€– Prompt for AI Agents
In @examples/angular/column-ordering/package.json around lines 13 - 30,
Standardize Angular package versions and build tooling across all examples by
updating every example's package.json so all "@angular/*" dependencies and
"@angular/compiler-cli" use the same patch version (e.g., ^21.0.8) and ensure
devDependencies use the unified build package "@angular/build" with the matching
patch (replace any "@angular-devkit/build-angular" entries and any outlier
versions like ^21.0.6 in the row-dnd example). Edit the "dependencies" entries
for "@angular/common", "@angular/compiler", "@angular/core", "@angular/forms",
"@angular/platform-browser", "@angular/platform-browser-dynamic" and the
"devDependencies" entry for "@angular/build"/"@angular/cli"/"typescript" so they
all reference the agreed-upon patch, and remove or replace any inconsistent
package names (e.g., swap "@angular-devkit/build-angular" to "@angular/build")
to keep tooling consistent.

Expand Down
18 changes: 9 additions & 9 deletions examples/angular/column-pinning-sticky/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@
},
"private": true,
"dependencies": {
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"tslib": "^2.8.1",
"typescript": "5.9.3"
}
Expand Down
20 changes: 10 additions & 10 deletions examples/angular/column-pinning/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^21.0.6",
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/animations": "^21.0.8",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"tslib": "^2.8.1",
"typescript": "5.9.3"
}
Expand Down
22 changes: 11 additions & 11 deletions examples/angular/column-resizing-performant/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^21.0.6",
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/router": "^21.0.6",
"@angular/animations": "^21.0.8",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@angular/router": "^21.0.8",
"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular-devkit/build-angular": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"@types/jasmine": "~5.1.13",
"jasmine-core": "~5.13.0",
"karma": "~6.4.4",
Expand Down
18 changes: 9 additions & 9 deletions examples/angular/column-visibility/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@
},
"private": true,
"dependencies": {
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"tslib": "^2.8.1",
"typescript": "5.9.3"
}
Expand Down
22 changes: 11 additions & 11 deletions examples/angular/editable/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^21.0.6",
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/router": "^21.0.6",
"@angular/animations": "^21.0.8",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@angular/router": "^21.0.8",
Comment on lines +13 to +20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | πŸ”΄ Critical

🧩 Analysis chain

🏁 Script executed:

cat examples/angular/editable/package.json

Repository: TanStack/table

Length of output: 1212


🏁 Script executed:

npm view @angular/core versions --json | tail -20

Repository: TanStack/table

Length of output: 597


🏁 Script executed:

npm view @angular/cli versions --json | tail -20

Repository: TanStack/table

Length of output: 613


🏁 Script executed:

git log --oneline -n 5 -- examples/angular/editable/package.json

Repository: TanStack/table

Length of output: 91


🏁 Script executed:

git show HEAD:examples/angular/editable/package.json | grep -A 20 '"dependencies"' | head -25

Repository: TanStack/table

Length of output: 745


🏁 Script executed:

git show 46b0643c^:examples/angular/editable/package.json 2>/dev/null | grep -A 20 '"dependencies"' | head -25

Repository: TanStack/table

Length of output: 40


🏁 Script executed:

git show 46b0643c^:examples/angular/editable/package.json 2>/dev/null | grep -A 15 '"devDependencies"'

Repository: TanStack/table

Length of output: 40


🏁 Script executed:

git log --all --full-history -- examples/angular/editable/package.json | head -20

Repository: TanStack/table

Length of output: 500


🏁 Script executed:

git diff 46b0643c~1 46b0643c -- examples/angular/editable/package.json 2>/dev/null | grep -A 5 -B 5 '@angular'

Repository: TanStack/table

Length of output: 40


🏁 Script executed:

git show 46b0643c~1:examples/angular/editable/package.json | cat

Repository: TanStack/table

Length of output: 98


🏁 Script executed:

git log --all --reverse -- examples/angular/editable/package.json | head -20

Repository: TanStack/table

Length of output: 500


🏁 Script executed:

git show 46b0643c:examples/angular/editable/package.json | grep -E '@angular|@angular-devkit'

Repository: TanStack/table

Length of output: 479


🏁 Script executed:

git show e172109fca4cc403a07236ed8fa103450ceba5e9:examples/angular/editable/package.json | grep -E '@angular|@angular-devkit'

Repository: TanStack/table

Length of output: 479


🏁 Script executed:

git diff e172109fca4cc403a07236ed8fa103450ceba5e9 46b0643c -- examples/angular/editable/package.json

Repository: TanStack/table

Length of output: 2089


Major version upgrade requires careful review, not approved as patch update.

The review comment incorrectly characterizes this change. The actual update is a major version jump from Angular 17.3.x to 21.x, not a patch update within the 21.0.x series:

  • @angular/* packages: 17.3.9 β†’ 21.0.8
  • @angular-devkit/build-angular: 17.3.8 β†’ 21.0.5
  • @angular/cli: 17.3.8 β†’ 21.0.5

Additionally, the review comment references @angular/[email protected], which does not exist in the npm registry; the latest 21.x version of @angular/cli is 21.0.5. The change correctly specifies 21.0.5 in the file but the review's characterization is inaccurate.

Major version upgrades across an entire framework warrant more thorough verification (breaking changes, dependency compatibility, migration guide alignment) beyond patch-level semantic versioning checks.

πŸ€– Prompt for AI Agents
In @examples/angular/editable/package.json around lines 13 - 20, The review
incorrectly labels the changes to "@angular/*", "@angular-devkit/build-angular"
and "@angular/cli" as a patch update; update the review comment to state this is
a major version bump from 17.3.x to 21.x, correct the referenced CLI version to
"@angular/[email protected]" (not 21.0.8), and call out that the package changes for
"@angular/animations", "@angular/common", "@angular/compiler", "@angular/core",
"@angular/forms", "@angular/platform-browser",
"@angular/platform-browser-dynamic", "@angular/router",
"@angular-devkit/build-angular" and "@angular/cli" require full migration checks
(breaking changes, dependency compatibility, and alignment with official
migration guides) rather than a patch-level approval.

"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular-devkit/build-angular": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"@types/jasmine": "~5.1.13",
"jasmine-core": "~5.13.0",
"karma": "~6.4.4",
Expand Down
22 changes: 11 additions & 11 deletions examples/angular/expanding/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^21.0.6",
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/router": "^21.0.6",
"@angular/animations": "^21.0.8",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@angular/router": "^21.0.8",
"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular-devkit/build-angular": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"tslib": "^2.8.1",
"typescript": "5.9.3"
}
Expand Down
18 changes: 9 additions & 9 deletions examples/angular/filters/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@
},
"private": true,
"dependencies": {
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"tslib": "^2.8.1",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"typescript": "5.9.3"
}
}
18 changes: 9 additions & 9 deletions examples/angular/grouping/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@
},
"private": true,
"dependencies": {
"@angular/common": "^21.0.6",
"@angular/compiler": "^21.0.6",
"@angular/core": "^21.0.6",
"@angular/forms": "^21.0.6",
"@angular/platform-browser": "^21.0.6",
"@angular/platform-browser-dynamic": "^21.0.6",
"@angular/common": "^21.0.8",
"@angular/compiler": "^21.0.8",
"@angular/core": "^21.0.8",
"@angular/forms": "^21.0.8",
"@angular/platform-browser": "^21.0.8",
"@angular/platform-browser-dynamic": "^21.0.8",
"@faker-js/faker": "^10.2.0",
"@tanstack/angular-table": "^9.0.0-alpha.10",
"rxjs": "~7.8.2",
"zone.js": "~0.16.0"
},
"devDependencies": {
"@angular/build": "^21.0.4",
"@angular/cli": "^21.0.4",
"@angular/compiler-cli": "^21.0.6",
"@angular/build": "^21.0.5",
"@angular/cli": "^21.0.5",
"@angular/compiler-cli": "^21.0.8",
"tslib": "^2.8.1",
"typescript": "5.9.3"
}
Expand Down
Loading
Loading