-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
move alpha to changesets #6145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
move alpha to changesets #6145
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json", | ||
| "changelog": [ | ||
| "@svitejs/changesets-changelog-github-compact", | ||
| { "repo": "TanStack/table" } | ||
| ], | ||
| "commit": false, | ||
| "access": "public", | ||
| "baseBranch": "alpha", | ||
| "updateInternalDependencies": "patch", | ||
| "fixed": [], | ||
| "linked": [], | ||
| "ignore": [], | ||
| "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": { | ||
| "onlyUpdatePeerDependentsWhenOutOfRange": true | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,6 @@ | ||
| name: ci | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| tag: | ||
| description: override release tag | ||
| required: false | ||
| push: | ||
| branches: [main, alpha, beta, rc] | ||
|
|
||
|
|
@@ -19,6 +14,7 @@ env: | |
| permissions: | ||
| contents: write | ||
| id-token: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| test-and-publish: | ||
|
|
@@ -39,13 +35,13 @@ jobs: | |
| - name: Stop Nx Agents | ||
| if: ${{ always() }} | ||
| run: npx nx-cloud stop-all-agents | ||
| - name: Publish | ||
| run: | | ||
| git config --global user.name 'Tanner Linsley' | ||
| git config --global user.email '[email protected]' | ||
| npm config set '//registry.npmjs.org/:_authToken' "${NPM_TOKEN}" | ||
| pnpm run cipublish | ||
| - name: Run Changesets (version or publish) | ||
| uses: changesets/[email protected] | ||
| with: | ||
| version: pnpm run changeset:version | ||
| publish: pnpm run changeset:publish | ||
| commit: 'ci: Version Packages' | ||
| title: 'ci: Version Packages' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| TAG: ${{ inputs.tag }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,23 +10,23 @@ | |
| }, | ||
| "private": true, | ||
| "dependencies": { | ||
| "@angular/animations": "^21.0.6", | ||
| "@angular/common": "^21.0.6", | ||
| "@angular/compiler": "^21.0.6", | ||
| "@angular/core": "^21.0.6", | ||
| "@angular/forms": "^21.0.6", | ||
| "@angular/platform-browser": "^21.0.6", | ||
| "@angular/platform-browser-dynamic": "^21.0.6", | ||
| "@angular/router": "^21.0.6", | ||
| "@angular/animations": "^21.0.8", | ||
| "@angular/common": "^21.0.8", | ||
| "@angular/compiler": "^21.0.8", | ||
| "@angular/core": "^21.0.8", | ||
| "@angular/forms": "^21.0.8", | ||
| "@angular/platform-browser": "^21.0.8", | ||
| "@angular/platform-browser-dynamic": "^21.0.8", | ||
| "@angular/router": "^21.0.8", | ||
|
Comment on lines
+13
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π§© Analysis chainπ Script executed: cat examples/angular/editable/package.jsonRepository: TanStack/table Length of output: 1212 π Script executed: npm view @angular/core versions --json | tail -20Repository: TanStack/table Length of output: 597 π Script executed: npm view @angular/cli versions --json | tail -20Repository: TanStack/table Length of output: 613 π Script executed: git log --oneline -n 5 -- examples/angular/editable/package.jsonRepository: TanStack/table Length of output: 91 π Script executed: git show HEAD:examples/angular/editable/package.json | grep -A 20 '"dependencies"' | head -25Repository: TanStack/table Length of output: 745 π Script executed: git show 46b0643c^:examples/angular/editable/package.json 2>/dev/null | grep -A 20 '"dependencies"' | head -25Repository: TanStack/table Length of output: 40 π Script executed: git show 46b0643c^:examples/angular/editable/package.json 2>/dev/null | grep -A 15 '"devDependencies"'Repository: TanStack/table Length of output: 40 π Script executed: git log --all --full-history -- examples/angular/editable/package.json | head -20Repository: TanStack/table Length of output: 500 π Script executed: git diff 46b0643c~1 46b0643c -- examples/angular/editable/package.json 2>/dev/null | grep -A 5 -B 5 '@angular'Repository: TanStack/table Length of output: 40 π Script executed: git show 46b0643c~1:examples/angular/editable/package.json | catRepository: TanStack/table Length of output: 98 π Script executed: git log --all --reverse -- examples/angular/editable/package.json | head -20Repository: TanStack/table Length of output: 500 π Script executed: git show 46b0643c:examples/angular/editable/package.json | grep -E '@angular|@angular-devkit'Repository: TanStack/table Length of output: 479 π Script executed: git show e172109fca4cc403a07236ed8fa103450ceba5e9:examples/angular/editable/package.json | grep -E '@angular|@angular-devkit'Repository: TanStack/table Length of output: 479 π Script executed: git diff e172109fca4cc403a07236ed8fa103450ceba5e9 46b0643c -- examples/angular/editable/package.jsonRepository: TanStack/table Length of output: 2089 Major version upgrade requires careful review, not approved as patch update. The review comment incorrectly characterizes this change. The actual update is a major version jump from Angular 17.3.x to 21.x, not a patch update within the 21.0.x series:
Additionally, the review comment references Major version upgrades across an entire framework warrant more thorough verification (breaking changes, dependency compatibility, migration guide alignment) beyond patch-level semantic versioning checks. π€ Prompt for AI Agents |
||
| "@faker-js/faker": "^10.2.0", | ||
| "@tanstack/angular-table": "^9.0.0-alpha.10", | ||
| "rxjs": "~7.8.2", | ||
| "zone.js": "~0.16.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "^21.0.4", | ||
| "@angular/cli": "^21.0.4", | ||
| "@angular/compiler-cli": "^21.0.6", | ||
| "@angular-devkit/build-angular": "^21.0.5", | ||
| "@angular/cli": "^21.0.5", | ||
| "@angular/compiler-cli": "^21.0.8", | ||
| "@types/jasmine": "~5.1.13", | ||
| "jasmine-core": "~5.13.0", | ||
| "karma": "~6.4.4", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π§© Analysis chain
π Script executed:
Repository: TanStack/table
Length of output: 2487
Resolve Angular version and build-tooling inconsistencies across examples.
The patch-version skew you flagged is confirmed: all 16 Angular examples mix
^21.0.5and^21.0.8across their@angular/*dependencies. Additionally, a build-tooling split existsβmost examples use@angular/build: ^21.0.5, but 6 examples (column-resizing-performant, editable, expanding, remote-data, row-dnd, sub-components) use@angular-devkit/build-angular: ^21.0.5instead. The row-dnd example also contains an outlier at^21.0.6. Standardize versions and build tooling across all Angular examples to prevent maintenance drift and compatibility issues.π€ Prompt for AI Agents