-
Notifications
You must be signed in to change notification settings - Fork 191
add stat counters to library pages #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
Looks like the build on Netlify is failing since we don't have the I'm not too familiar with whether our Convex setup, but is it fine use the same key for the deploy previews? Let me know, I can duplicate the key in Netlify's dashboard for the website. Or perhaps, can changes be made where the key isn't explicitly needed? If needed, we can PM in a thread in the Convex channel on the TanStack Discord server. |
@SeanCassiere yeah I posted instructions in the discord instead of here for some reason 🤦♂️ - that's where Tanner said we may as well just set up Convex deploy previews to support this flow anyway.
|
was there more work to be done on this pr besides getting the preview deployment working? |
@KevinVandy no, just Tanner being happy with the outcome |
Parses the library object to keep it simple. Everything works, but there's no simple way to link from NPM download counts to something sensible because most have multiple framework variants. Would be cool to maybe have the framework links pop up if you hover or something?
I'm probably overthinking this one lol. Let me know what you think.