Skip to content

add stat counters to library pages #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erquhart
Copy link
Contributor

Parses the library object to keep it simple. Everything works, but there's no simple way to link from NPM download counts to something sensible because most have multiple framework variants. Would be cool to maybe have the framework links pop up if you hover or something?

I'm probably overthinking this one lol. Let me know what you think.

Copy link

netlify bot commented Jul 22, 2025

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7ebf0cf

@erquhart erquhart requested a review from SeanCassiere July 25, 2025 15:22
@SeanCassiere
Copy link
Member

Looks like the build on Netlify is failing since we don't have the CONVEX_DEPLOY_KEY applied for deployment previews.

I'm not too familiar with whether our Convex setup, but is it fine use the same key for the deploy previews? Let me know, I can duplicate the key in Netlify's dashboard for the website.

Or perhaps, can changes be made where the key isn't explicitly needed?

If needed, we can PM in a thread in the Convex channel on the TanStack Discord server.

@erquhart
Copy link
Contributor Author

erquhart commented Jul 29, 2025

@SeanCassiere yeah I posted instructions in the discord instead of here for some reason 🤦‍♂️ - that's where Tanner said we may as well just set up Convex deploy previews to support this flow anyway.

Actually, I think I was able to get almost everything done, Netlify stuff is in a netlify.toml update in the PR.

Someone from your team with access to Convex and Netlify just needs to:

@KevinVandy
Copy link
Member

was there more work to be done on this pr besides getting the preview deployment working?

@erquhart
Copy link
Contributor Author

@KevinVandy no, just Tanner being happy with the outcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants