feat: top menu for mobile resolution with sheet menu #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Mbeaulne
approved these changes
Jan 8, 2026
Collaborator
There was a problem hiding this comment.
Not blocking, but instead of a sheet which hides the buttons, maybe we just make them icon buttons? Also, maybe we remove the text on the buttons:
Clone pipeline -> Clone
Import pipeline -> Import
New pipeline -> New
I think having "pipeline" next to each button clutters up the UI. We should consider removing it.
I also wonder if we should make the menu a little more consistant with the other buttons and remove the white background:
maxy-shpfy
changed the base branch from
01-07-fix_responsive_top_menu
to
graphite-base/1604
maxy-shpfy
force-pushed
the
graphite-base/1604
branch
from
efc6c5f to
0f39d59
Compare
maxy-shpfy
force-pushed
the
01-07-feat_top_menu_for_mobile_resolution_with_sheet_menu
branch
from
0ff0476 to
86fb7da
Compare
maxy-shpfy
force-pushed
the
01-07-feat_top_menu_for_mobile_resolution_with_sheet_menu
branch
from
86fb7da to
4c7a7a6
Compare
Collaborator
Author
|
I agree, this is not the final stage of the top menu design. But just a small step towards. |
Collaborator
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/Shopify/oasis-frontend/issues/404
Added a responsive mobile menu to the application header. The PR implements a hamburger menu that appears on mobile devices, providing access to actions like Clone Run, Import Pipeline, and New Pipeline buttons that were previously only visible on desktop. The mobile menu is implemented using a Sheet component that slides in from the right side when activated.
Type of Change
Checklist
Test Instructions
Screen Recording 2026-01-07 at 9.36.20 PM.mov (uploaded via Graphite)