feat: Improve visual contrast between Pipelines and Runs #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Changes:** * Removes grid when viewing a read-only run * Adds a background color to the Runs view that is different from the Pipelines view * Adds breadcrumbs that intelligently detects if a pipeline exists locally and gives the user the capability of navigating to the pipeline that triggered the run
morgan-wowk
force-pushed
the
01-09-feat_improve_visual_contrast_between_pipelines_and_runs
branch
from
6307c8c to
9f556af
Compare
Author
|
CC: @Mbeaulne This is a change I have had sitting on my local since my first week. It stems from some confusion I and others have been experiencing about whether they are viewing a run or a pipeline - where people are currently relying on looking at which sidebars they are seeing, or certain symbols attached to the nodes. |
Author
|
Would love to hear your thoughts! If you like it, we can try tweaking it after the other visual improvements you are planning |
Author
|
Disregard the icon being in the title bar on one page but not the other. That is weird and I will fix that if we move forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added breadcrumbs navigation to the Pipeline Run page, allowing users to navigate between pipeline runs and the editor. The breadcrumbs show the pipeline name and run ID, with the ability to:
Also updated the flow canvas background from the previous
<Background>component to a simple gray background color.Type of Change
Checklist
Screenshots (if applicable)
runs-contrast.mov (uploaded via Graphite)
Test Instructions