Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Jan 15, 2026

Description

Extract Task Actions into individual Button Components and then render them conditionally within TaskActions.

Currently the definition of actions on a task is scattered across multiple different files in an ever-growing actions array. This change simplifies things greatly: actions are defined as their own button and then rendered via TaskActions.

This change separates concerns for all the different task actions and substantially reduces the amount of code lingering about in TaskNodeCard, TaskOverview, TaskActions and ComponentDetailsDialog.

Note: this change renders the general Action Framework created in #1470 somewhat obsolete. However, since the framework was initially created to support ReactNodes for backward-compatibility not change is actually needed to the framework. For now it can be left in place and in the future we can choose to use it or remove it.

Next Steps: Pipeline & Run Actions

Related Issue and Pull requests

Supersedes #1534

Related to https://github.com/Shopify/oasis-frontend/issues/401

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

No change to UI.

Test Instructions

Check that every button in the task details panel and component details dialog works as expected.

Additional Comments

Copy link
Collaborator Author

camielvs commented Jan 15, 2026

@camielvs camielvs force-pushed the 01-14-chore_cleanup_task_action_buttons branch from d2c1b97 to d85b1e2 Compare January 15, 2026 03:40
@camielvs camielvs changed the base branch from master to graphite-base/1633 January 15, 2026 04:20
@camielvs camielvs force-pushed the 01-14-chore_cleanup_task_action_buttons branch from d85b1e2 to ff49a5b Compare January 15, 2026 04:20
@camielvs camielvs changed the base branch from graphite-base/1633 to 12-10-rework_codeviewer_implementation January 15, 2026 04:21
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 448e775 to 950e030 Compare January 15, 2026 04:25
@camielvs camielvs force-pushed the 01-14-chore_cleanup_task_action_buttons branch from ff49a5b to 8feaa0e Compare January 15, 2026 04:25
@camielvs camielvs marked this pull request as ready for review January 15, 2026 04:26
@camielvs camielvs requested a review from a team as a code owner January 15, 2026 04:26
Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Download Python" button is not displayed, when it needs to display.

Screen Recording 2026-01-15 at 11.16.22 AM.mov (uploaded via Graphite) is

Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve! I tested and everything seems to works nicely! I love how it turns to be.

Merge contingent upon the bugfix with Python button.

@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 950e030 to 260200e Compare January 15, 2026 19:42
@camielvs camielvs force-pushed the 01-14-chore_cleanup_task_action_buttons branch from 8feaa0e to 8754816 Compare January 15, 2026 19:42
@camielvs camielvs changed the base branch from 12-10-rework_codeviewer_implementation to graphite-base/1633 January 16, 2026 00:35
@camielvs camielvs force-pushed the 01-14-chore_cleanup_task_action_buttons branch from 8754816 to aa5319d Compare January 16, 2026 00:38
@graphite-app graphite-app bot changed the base branch from graphite-base/1633 to master January 16, 2026 00:38
@camielvs camielvs force-pushed the 01-14-chore_cleanup_task_action_buttons branch from aa5319d to a71bd70 Compare January 16, 2026 00:38
Copy link
Collaborator Author

camielvs commented Jan 16, 2026

Merge activity

  • Jan 16, 12:42 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 12:42 AM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs merged commit 6b84d09 into master Jan 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants