-
Notifications
You must be signed in to change notification settings - Fork 5
chore: Cleanup Task Action Buttons #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d2c1b97 to
d85b1e2
Compare
d85b1e2 to
ff49a5b
Compare
448e775 to
950e030
Compare
ff49a5b to
8feaa0e
Compare
maxy-shpfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Download Python" button is not displayed, when it needs to display.
Screen Recording 2026-01-15 at 11.16.22 AM.mov (uploaded via Graphite) is
src/components/shared/TaskDetails/Actions/DownloadPythonButton.tsx
Outdated
Show resolved
Hide resolved
maxy-shpfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve! I tested and everything seems to works nicely! I love how it turns to be.
Merge contingent upon the bugfix with Python button.
950e030 to
260200e
Compare
8feaa0e to
8754816
Compare
260200e to
80ffdbe
Compare
8754816 to
aa5319d
Compare
aa5319d to
a71bd70
Compare

Description
Extract Task Actions into individual Button Components and then render them conditionally within
TaskActions.Currently the definition of actions on a task is scattered across multiple different files in an ever-growing
actionsarray. This change simplifies things greatly: actions are defined as their own button and then rendered viaTaskActions.This change separates concerns for all the different task actions and substantially reduces the amount of code lingering about in
TaskNodeCard,TaskOverview,TaskActionsandComponentDetailsDialog.Note: this change renders the general Action Framework created in #1470 somewhat obsolete. However, since the framework was initially created to support ReactNodes for backward-compatibility not change is actually needed to the framework. For now it can be left in place and in the future we can choose to use it or remove it.
Next Steps: Pipeline & Run Actions
Related Issue and Pull requests
Supersedes #1534
Related to https://github.com/Shopify/oasis-frontend/issues/401
Type of Change
Checklist
Screenshots (if applicable)
No change to UI.
Test Instructions
Check that every button in the task details panel and component details dialog works as expected.
Additional Comments