forked from PhilipsHue/flutter_reactive_ble
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: session restoration #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taylorbell
wants to merge
25
commits into
master
Choose a base branch
from
feat/session-restoration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the changes from f880ed8 with some additional changes to clean up merge conflicts and fix broken tests.
This refactors the device restoration logic to emit a stream of `RestoredDevice` objects on session restoration. Each device will have a set of metadata as well as streams for the connection state as well as any characteristic subscriptions established in a previous session. Each stream provides the same functionality as a standard connection or characteristic stream and will disconnect/unsubscribe on calling `cancel()`.
This passes an empty restored device info collection to the restored device event stream on Android to ensure the stream will emit a done event.
This doesn't fully prevent duplicate emissions but should ensure duplicates aren't emitted during connection and initial pairing when it is most important.
feat: add support for monitoring ble device bond status changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new branch with the previous work done by @dballance cherry-picked on top of the latest from the main repository. Additionally some tweaks/fixes have been made to account for changes in the API upstream as well as to get unittests running and passing.