Skip to content

Fix text metrics kerning calculation #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eXpl0it3r merged 1 commit into from
Aug 28, 2025
Merged

Fix text metrics kerning calculation #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/SFGUI/Engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,31 +183,38 @@ sf::Vector2f Engine::GetTextStringMetrics( const sf::String& string, const sf::F
auto longest_line = 0.f;

for( const auto& current_character : string ) {
metrics.x += static_cast<float>( font.getKerning( previous_character, current_character, font_size ) );

switch( current_character ) {
case L' ':
metrics.x += horizontal_spacing;
continue;
break;

case L'\t':
metrics.x += horizontal_spacing * tab_spaces;
continue;
break;

case L'\n':
metrics.y += vertical_spacing;
longest_line = std::max( metrics.x, longest_line );
metrics.x = 0.f;
continue;
break;

case L'\v':
metrics.y += vertical_spacing * tab_spaces;
continue;
default:
break;
}

const auto& glyph = font.getGlyph( current_character, font_size, false );
default:
if( previous_character != 0 ) {
metrics.x += static_cast<float>( font.getKerning( previous_character, current_character, font_size ) );
}

metrics.x += static_cast<float>( glyph.advance );
metrics.y = std::max( metrics.y, static_cast<float>( glyph.bounds.size.y ) );
previous_character = current_character;

const auto& glyph = font.getGlyph( current_character, font_size, false );
metrics.x += static_cast<float>( glyph.advance );
metrics.y = std::max( metrics.y, static_cast<float>( glyph.bounds.size.y ) );

break;
}
}

metrics.x = std::max( longest_line, metrics.x );
Expand Down