-
Notifications
You must be signed in to change notification settings - Fork 10
add nix package and nixosModule #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
hey @e-v-o-l-v-e , thanks for this PR - glad you like the app i've not played with nix and am running low on time, so give me a bit to review, will merge this soon |
|
no problems ! if you're interested i recommend https://nixos-and-flakes.thiscute.world/ I've just refactored the flake to allow use on different architecture, and rebased my changes to have only one commit. No problem take your time, in the meantime if someone wants to use with nix it they can do so with my fork : nix run github:e-v-o-l-v-e/local-content-share |
|
I basically rewrote everything but better, now support any unix system whereas it was only x86 linux before, and added the nixos module because for some reason it is still not merged in nixpkgs. the readme update is the most important part though, i added everything as 3 folding section so it doesn't take too much space, feel free to ask me any question, I can add comments if what the flake does isn't clear the link update is really cool, still an amazing software, keep up the good work ^^ (if someone wants to use the nixosModule before this gets merge you just need to use my fork as the inputs : local-content-share = {
url = "github:e-v-o-l-v-e/local-content-share";
inputs.nixpkgs.follows = "nixpkgs";
}; |
|
hey @e-v-o-l-v-e , sorry for the delay here! thanks for your updates. i'll wait to merge till the nixpkgs PR is merged. until then, 2 quick comments:
thanks, and i'll periodically check that pr and merge this one when complete |
1fa85b1 to
099b64f
Compare
|
hey, sorry for the delay, I just got back to school so not a lot of free time 😅, here are the changes, i kept the notive for the unmerged PR though, because it has been sitting there for 2 month and i don't know if it's ever gonna get merged 🥲 |
1e707f2 to
e291af9
Compare
|
my PR has finally been merged in Nixpkgs ! I edited the readme accordingly, and made the flake better |
Hello, if you're open to this, it just adds a flake.nix and a flake.lock to allow use with Nix.
It will not require anything more from you, and it's mostly temporary, I already submitted a PR to add the package it in nixpkgs (the repo for nix packages) and I plan to make it a nixos module afterwards.
I'll update the version number and the flake.lock when needed.
thank you for the software btw, it's really cool, I use it all the time.