This repository was archived by the owner on Jul 4, 2023. It is now read-only.
prevent from NPE, add a multi get returning list of pair of (key maps)#10
Open
worldline-messaging wants to merge 15 commits intoTapad:masterfrom
Open
prevent from NPE, add a multi get returning list of pair of (key maps)#10worldline-messaging wants to merge 15 commits intoTapad:masterfrom
worldline-messaging wants to merge 15 commits intoTapad:masterfrom
Conversation
add a multi get returning list of pair key maps add the scanall functionality do block when we reach max commands
|
That null check actually seems to be necessary - should probably have been spelled out in their docs that they simply return a null instead of an empty collection in case you request no bins. |
…he other writings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if(rec.bins!=null) { to prevent from NullPointerException ( you can pass an empty set as parameter of the query )
multiQueryL is better when you want to keep the order of the keys passed as parameter. With a map you loose the order in the result.
For the WriteSettings, i prefere to send key by default.
Blocking is just a question of choice.