Skip to content

Fix Java 11+ compatibility by removing internal JDK API usage #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −7
Open

Fix Java 11+ compatibility by removing internal JDK API usage #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abe6a81
Initial plan
Copilot Jan 1, 2026
c3e5bde
Fix Java 11+ compatibility issues for compilation
Copilot Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/test/java/com/qq/tars/TestForGenericType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

import junit.framework.Assert;
import org.junit.Test;
import sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl;

import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
import java.util.List;
import java.util.concurrent.CompletableFuture;
Expand All @@ -25,7 +25,7 @@ public void testGenerictype() throws InvocationTargetException, IllegalAccessExc
Type type = method.getGenericReturnType();
Type type2 = method.getReturnType();
Assert.assertEquals(type2, CompletableFuture.class);
ParameterizedTypeImpl parameterizedType = (ParameterizedTypeImpl) method.getGenericReturnType();
ParameterizedType parameterizedType = (ParameterizedType) method.getGenericReturnType();
Assert.assertEquals(parameterizedType.getActualTypeArguments()[0].getTypeName(), "java.util.List<java.lang.Integer>");
System.out.println(parameterizedType.getActualTypeArguments()[0].getTypeName());
System.out.println("get inner type is " + parameterizedType.getActualTypeArguments()[0]);
Expand Down
5 changes: 5 additions & 0 deletions spring/tars-spring-cloud-starter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@
</properties>

<dependencies>
<dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
<version>1.3.2</version>
</dependency>
<dependency>
<groupId>com.netflix.eureka</groupId>
<artifactId>eureka-client</artifactId>
Expand Down
3 changes: 0 additions & 3 deletions tars-common-api/src/main/java/com/qq/tars/common/ClientVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@

package com.qq.tars.common;

import jdk.nashorn.internal.ir.annotations.Immutable;

@Immutable
public final class ClientVersion {

// public static final String major = "1";
Expand Down
3 changes: 1 addition & 2 deletions tars-common-api/src/main/java/com/qq/tars/protocol/util/TarsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import com.qq.tars.protocol.tars.support.TarsMethodParameterInfo;
import com.qq.tars.protocol.tars.support.TarsStructInfo;
import com.qq.tars.protocol.tars.support.TarsStrutPropertyInfo;
import sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl;

import java.lang.annotation.Annotation;
import java.lang.reflect.Array;
Expand Down Expand Up @@ -477,7 +476,7 @@ public static TarsMethodInfo getMethodInfo(Class<?> api, Method method, String o
Type returnOriginType = method.getReturnType();

if (returnOriginType == CompletableFuture.class) {
ParameterizedTypeImpl parameterizedType = (ParameterizedTypeImpl) method.getGenericReturnType();
ParameterizedType parameterizedType = (ParameterizedType) method.getGenericReturnType();
TarsMethodParameterInfo returnInfo = new TarsMethodParameterInfo();
returnInfo.setStamp(TarsHelper.getParameterStamp(parameterizedType.getActualTypeArguments()[0]));//CompletableFuture use gengeric inner type class
returnInfo.setName("result");
Expand Down