hash<> SFINAE protection #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think basing it off of libc++'s implementation is a licensing issue, as this library is CC0 licensed and libc++ is under MIT, so I'd need to include the MIT license for the hash implementation and fewer projects would be able to use this library. IANAL though. |
|
I don't think this classifies as a "substantial portion" of the original software, so you should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that under the hash specialization of tl::optional, there was a TODO for a SFINAE guard. The guard I implemented is based off of libc++'s but unlike their implementation, mine works for C++11.