version 0.2.7 #23
Merged
version 0.2.7 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Fixed [BUG 1654](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1654) This PR enhances the unit test suite for the `OSM2OSW` conversion module by adding comprehensive validation of the generated GeoJSON files. It ensures structural integrity and proper preservation of `ext:` tags during the OSM-to-OSW conversion process. --- ### Changes Made - Added test to verify presence of `ext` tags in generated feature properties - Verified all output files are valid GeoJSON FeatureCollections - Ensured `nodes` files contain only Point geometries - Validated that all feature `_id` properties are strings - Asserted no features are missing geometry or coordinates - Checked that no duplicate `_id` values exist within any generated file --- ### Motivation These tests address regression concerns related to dropped `ext` tags in output. They also help guarantee conformance with the OSW schema expectations. --- ### Test Plan Run: ```bash python -m unittest discover -v tests/unit_tests
…to OSM XML. - Asserts that the number of nodes and ways is identical between the original and the final XML files. - Optionally, checks that the tags for nodes and ways are preserved where IDs match.
susrisha
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.2.7
exttagsUnit Tests
nodesfiles contain only Point geometries_idproperties are strings_idvalues exist within any generated file