Fixed [TASK 2040] #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed [BUG 1654](https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/1654) - Added functionality to retain the `ext` tags
sureshgaussian
requested changes
Jun 13, 2025
Contributor
sureshgaussian
left a comment
sureshgaussian
left a comment
There was a problem hiding this comment.
The tests added seem to be when we go from OSW -> OSM. We also need tests going from OSM->OSW. Specifically, if we get inputs like this: where as you can see width's value is 1.525 but is represented as a string, do we handle this? I cannot see this being handled.
In addition, lets also add real files as test cases that one can run and see the outputs.
susrisha
previously approved these changes
Jun 16, 2025
sureshgaussian
approved these changes
Jun 18, 2025
Contributor
sureshgaussian
left a comment
sureshgaussian
left a comment
There was a problem hiding this comment.
Approved after code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.