[0.2.12] Fixed-2409 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Dev Board Ticket https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2409 ## Changes - Updated OSMTaggedNodeParser to apply the OSW node and point filters with normalization before adding loose tagged nodes, ensuring non-compliant features like crossings are no longer emitted. - Extended serializer tests to cover the new tagged-node behavior, confirming that compliant kerb features are retained while schema-invalid crossings are skipped. - Updated GeoJSON node export to normalize IDs, retain full OSM identifiers, and skip non-OSW features so schema-invalid crossings are no longer emitted. - Ensured only synthetic node IDs have their prefix trimmed, fixing the prior bug where numeric IDs lost the leading digit and caused _id/ext:osm_id mismatches. - Expanded serializer tests to cover OSW-compliant node export, rejection of non-compliant crossings, and prefix handling for generated point IDs. - Refined GeoJSON export to filter nodes using tag-only metadata, preventing schema-invalid features from being emitted. - Normalized ext:osm_id handling to preserve full numeric identifiers while trimming prefixed synthetic values. - Updated package version `0.2.12` - Updated ChangeLog ## Testing - Added 10 new unit test cases
sureshgaussian
approved these changes
Oct 13, 2025
Contributor
sureshgaussian
left a comment
sureshgaussian
left a comment
There was a problem hiding this comment.
approved after testing the branch code locally with a couple of examples.
susrisha
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2409
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2422
Changes
OSMTaggedNodeParser Enhancements
Serializer & Test Coverage
GeoJSON Node Export Improvements
Filtering & Metadata Handling
Identifier Normalization
0.2.12.Testing