feat: Add tests for remaining core logic#17
Draft
google-labs-jules[bot] wants to merge 2 commits intodevelopfrom
Draft
feat: Add tests for remaining core logic#17google-labs-jules[bot] wants to merge 2 commits intodevelopfrom
google-labs-jules[bot] wants to merge 2 commits intodevelopfrom
Conversation
- Introduce `vitest` and `jsdom` for unit testing.
- Add `vitest.config.ts` to configure the test environment, including path aliases.
- Add unit tests for the following utilities:
- `translateJosa.ts`
- `generateUniqueId.ts`
- `replaceSubstring.ts`
- `parseHtmlToArray.ts`
- `HtmlProcessor.ts`
- Fix bugs discovered in `translateJosa.ts` and `HtmlProcessor.ts` during test implementation.
- Add comprehensive tests for AI-related services and utilities, including `AiService`, `refineForeign`, `dify`, `analyzeMorpheme`, and `findForeignWord`. This involved extensive mocking of dependencies like `axios` and `@tensorflow/tfjs`. - Add tests for state management logic, including the `useFileStore` Zustand store and the `DocumentManager` orchestrator class. - Add `npm test` script to `package.json` for easy execution of all tests. - Add `@testing-library/react` to support testing of stores and hooks. - Fix bugs discovered in `getSurroundingWordsByOriginId.ts` during test implementation.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change completes the introduction of testing to the project. It adds comprehensive unit tests for the remaining core logic, including AI services, state management stores, and utility functions. It also adds a convenient
npm testscript to run the full test suite.