Skip to content

Conversation

@giordano
Copy link
Member

@giordano giordano commented Nov 5, 2025

Also, delete manifest now that we can point to the right ParticleDA using the [sources] section of the project file. This should make it easier to run benchmarks when updating list of dependencies of ParticleDA.

@giordano giordano mentioned this pull request Nov 5, 2025
@giordano giordano force-pushed the mg/benchmarks-v1.11 branch 2 times, most recently from 46bc9fc to 8b3d2ba Compare November 5, 2025 14:50
Also, delete manifest now that we can point to the right `ParticleDA` using the
`[sources]` section of the project file.  This should make it easier to run
benchmarks when updating list of dependencies of `ParticleDA`.
@giordano giordano force-pushed the mg/benchmarks-v1.11 branch from 8b3d2ba to ee8a342 Compare November 5, 2025 15:20
@giordano
Copy link
Member Author

giordano commented Nov 5, 2025

Well, I'm missing why the CI job claims that it can't push the the benchmark results branch, because it very much did push.

Anyway, benchmarks are running correctly, and using the right package (i.e. the local one, as intended) without using the manifest at all thanks to the [sources] section of the project file, so this is good to go now.

@giordano giordano merged commit a813e98 into main Nov 5, 2025
0 of 2 checks passed
@giordano giordano deleted the mg/benchmarks-v1.11 branch November 5, 2025 16:28
@giordano
Copy link
Member Author

giordano commented Nov 5, 2025

Oh, I just realised that also failed in #302, but I think it's the second full run within a PR which "fails" to push the results to the branch.

Edit: that PR implicitly changed the status permission from write to read. Addressed in #304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants