Run Aqua tests

[giordano]

Diff better reviewed by ignoring whitespace changes.

[giordano]

Oof, Aqua tests are failing because the OpenMPI dependency introduced in #296 is actually unused (and it should be, that was a hack...)

[giordano]

Uh uh, Aqua detected an(other) actual issue:

Possible type-piracy detected:
[1] ldiv!(A::PDMat, B::AbstractMatrix) @ ParticleDA ~/work/ParticleDA.jl/ParticleDA.jl/src/filters.jl:191
Piracy: Test Failed at /Users/runner/.julia/packages/Aqua/MCcFg/src/piracies.jl:245
  Expression: isempty(v)
   Evaluated: isempty(Method[ldiv!(A::PDMat, B::AbstractMatrix) @ ParticleDA ~/work/ParticleDA.jl/ParticleDA.jl/src/filters.jl:191])

ParticleDA.jl/src/filters.jl

Lines 190 to 191 in c101d0d

	# ldiv! not currently defined for PDMat so define here
	LinearAlgebra.ldiv!(A::PDMat, B::AbstractMatrix) = ldiv!(A.chol, B)

[giordano]

@matt-graham I'm just inlining the method I removed above, without explicitly defining a method which commits type piracy. Does it sound good? Tests pass locally for me with this change.

[matt-graham]

Yeah can't really remember why I explicitly defined method here as it looks like cov_Y_Y will always be a subtype of AbstractPDMat, but I suspect I was originally trying to allow for cov_Y_Y being of other abstract matrix types and wasn't aware of type piracy issues. Change looks fine - possibly

Suggested change

	ldiv!(cov_Y_Y.chol, observation_buffer)
	ldiv!(cholesky(cov_Y_Y), observation_buffer)

might be better to make code more generic / not explicitly access chol field? But this is tangential to change here.

[giordano]

Right, that's actually similar to what they do in PDMats: https://github.com/JuliaStats/PDMats.jl/blob/5046635eba5a44901b7cec0ca68c48cf8ed967d9/src/pdmat.jl#L129, but they use also internal functions chol_lower/chol_upper

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (c101d0d) to head (e3a147f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   94.50%   94.49%   -0.01%     
==========================================
  Files           9        9              
  Lines         655      654       -1     
==========================================
- Hits          619      618       -1     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.