Skip to content

Replace OrdinaryDiffEq with OrdinaryDiffEqTsit5 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giordano merged 2 commits into from
Nov 6, 2025
Merged

Replace OrdinaryDiffEq with OrdinaryDiffEqTsit5 #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd0b137
Replace `OrdinaryDiffEq` with `OrdinaryDiffEqTsit5`
giordano Nov 5, 2025
b2acbbe
Load ForwardDiff to make this work
giordano Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ChunkSplitters = "ae650224-84b6-46f8-82ea-d812ca08434e"
DelimitedFiles = "8bb1440f-4735-579b-a4ab-409b98df4dab"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
GaussianRandomFields = "e4b2fa32-6e09-5554-b718-106ed5adafe9"
HDF5 = "f67ccb44-e63f-5c2f-98bd-6dc0ccc4ba2f"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
MPI = "da04e1cc-30fd-572f-bb4f-1f8673147195"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
OrdinaryDiffEqTsit5 = "b1df2697-797e-41e3-8120-5422d3b24e4a"
PDMats = "90014a1f-27ba-587c-ab20-58faa44d9150"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
Expand All @@ -20,11 +21,12 @@ Aqua = "0.8"
ChunkSplitters = "3.1"
DelimitedFiles = "<0.0.1, 1"
Distributions = "0.22, 0.23, 0.24, 0.25"
ForwardDiff = "1.2"
GaussianRandomFields = "2.2.1"
HDF5 = "0.14, 0.15, 0.16, 0.17"
LinearAlgebra = "<0.0.1, 1"
MPI = "0.20.8"
OrdinaryDiffEq = "6.40"
OrdinaryDiffEqTsit5 = "1.5"
PDMats = "0.11"
Random = "<0.0.1, 1"
StableRNGs = "1"
Expand Down
6 changes: 4 additions & 2 deletions test/models/lorenz63.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ using Distributions
using HDF5
using Random
using PDMats
using OrdinaryDiffEq
# `ForwardDiff` is only needed to trigger loading a pkgextension.
import ForwardDiff as _
Comment on lines +8 to +9
Copy link
Member Author

@giordano giordano Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this was necessary because of SciML/OrdinaryDiffEq.jl#2900. This workaround can be removed in the future when that issue is fixed.

using OrdinaryDiffEqTsit5: OrdinaryDiffEqTsit5, Tsit5, ODEProblem, reinit!, step!
using ParticleDA

Base.@kwdef struct Lorenz63ModelParameters{S <: Real, T <: Real}
Expand Down Expand Up @@ -50,7 +52,7 @@ function init(
parameters = get_params(Lorenz63ModelParameters{S, T}, parameters_dict)
time_span = (0, parameters.time_step)
integrators = [
OrdinaryDiffEq.init(
OrdinaryDiffEqTsit5.init(
ODEProblem(update_time_derivative!, u, time_span, parameters),
Tsit5();
save_everystep=false
Expand Down