Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
baekjaehyuk
reviewed
May 23, 2025
Collaborator
baekjaehyuk
left a comment
baekjaehyuk
left a comment
There was a problem hiding this comment.
말씀해 주신 것처럼 soft delete에 대한 논의는 필요할 것 같습니다.
추가로 유저에 대한 프로필 삭제와 더불어 해당 유저의 영수증에 대한 데이터도 처리가 빠진 거 같습니다.
Comment on lines
18
to
22
| @DeleteMapping("/delete") | ||
| @Override | ||
| public void deleteMyAccount(@LoginUser User user) { | ||
| deleteUserUseCase.deleteUser(user); | ||
| } |
Collaborator
There was a problem hiding this comment.
현재 DeleteMapping으로 삭제에 대한 행위를 표현하고 있어 /delete 는 삭제해도 좋을 거 같습니다.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 개요
✅ 작업 내용
📂 리뷰 요구사항