Conversation
sohyun127
added
🛠️ [CHORE]
Walkthrough새 팀 프로필 아이콘 3종(VectorDrawable)을 추가하고, 경기 카드에서 팀-아이콘 매핑을 확장했다. 경기 스코어 TextView 두 개를 GONE으로 변경하고 구분자 텍스트를 ":"에서 "VS"로 수정했다. 빌드 타겟과 컴파일 SDK를 35로 올리고 앱 버전/코드를 갱신했다. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (10)
core/common/src/main/res/drawable/ic_news_team_profile_100t.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_blg.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_cfo.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_fly.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_fnc.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_g2.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_ig.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_tes.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_tsw.pngis excluded by!**/*.pngcore/common/src/main/res/drawable/ic_news_team_profile_vks.pngis excluded by!**/*.png
📒 Files selected for processing (6)
core/common/src/main/res/drawable/ic_news_team_profile_al.xml(1 hunks)core/common/src/main/res/drawable/ic_news_team_profile_mkoi.xml(1 hunks)core/common/src/main/res/drawable/ic_news_team_profile_psg.xml(1 hunks)feature/news/src/main/java/com/teamwable/news/match/NewsMatchScoreViewHolder.kt(1 hunks)feature/news/src/main/res/layout/item_news_match_score.xml(3 hunks)gradle/libs.versions.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: PR Checker
🔇 Additional comments (6)
feature/news/src/main/res/layout/item_news_match_score.xml (2)
83-83: 스코어 숨김 처리가 올바르게 구현되었습니다.
android:visibility="gone"을 사용하여 스코어를 숨기면서도 레이아웃 제약조건은 유지되므로, 향후 스코어를 다시 표시해야 할 때 visibility만 변경하면 됩니다.Also applies to: 108-108
93-95: VS 라벨 스타일 변경이 적절합니다.":"에서 "VS"로 텍스트를 변경하고
Head0에서Head1로,gray에서black으로 스타일을 변경하여 시각적으로 더 명확한 구분자를 제공합니다.core/common/src/main/res/drawable/ic_news_team_profile_psg.xml (1)
1-64: PSG 팀 프로필 아이콘이 올바르게 추가되었습니다.벡터 드로어블이 적절한 크기(44dp x 44dp)로 정의되었고,
NewsMatchScoreViewHolder.kt에서 정상적으로 참조됩니다.core/common/src/main/res/drawable/ic_news_team_profile_mkoi.xml (1)
1-19: MKOI 팀 프로필 아이콘이 올바르게 추가되었습니다.벡터 드로어블이 일관된 크기(44dp x 44dp)로 정의되었고,
NewsMatchScoreViewHolder.kt에서 정상적으로 참조됩니다.core/common/src/main/res/drawable/ic_news_team_profile_al.xml (1)
1-34: AL 팀 프로필 아이콘이 올바르게 추가되었습니다.벡터 드로어블이 일관된 크기(44dp x 44dp)로 정의되었고,
NewsMatchScoreViewHolder.kt에서 정상적으로 참조됩니다.gradle/libs.versions.toml (1)
2-6: Android 15(API 35) 주요 변경사항 검증
SDK 레벨을 35로 올린 후, 다음 항목을 앱 전반에서 직접 테스트하고 호환성을 확인하세요:
- Edge-to-edge(WindowInsets) 및 투명 상태/내비게이션 바 처리
- Foreground-service: dataSync·mediaProcessing 6시간 타임아웃, BOOT_COMPLETED·SYSTEM_ALERT_WINDOW 제약
- DND 정책 접근 방식(AutomaticZenRule) 변경
- Audio focus 요청: 최상위 앱 또는 포그라운드 서비스 조건
- String.format() 유효성 강화
- Kotlin List.removeFirst()/removeLast() 대신 removeAt() 또는 API 레벨 가드
- 제한된 Non-SDK API 및 호환성 플래그(ENFORCE_EDGE_TO_EDGE 등)
- PendingIntent 백그라운드 액티비티 런칭 기본 차단
- 로케일 글꼴(metrics/line-height) 변경
위 항목별 코드·테스트를 업데이트하고 주요 호환성 이슈를 검증하세요.
Comment on lines
+63
to
+75
| "BLG" -> com.teamwable.common.R.drawable.ic_news_team_profile_blg | ||
| "AL" -> com.teamwable.common.R.drawable.ic_news_team_profile_al | ||
| "TES" -> com.teamwable.common.R.drawable.ic_news_team_profile_tes | ||
| "IG" -> com.teamwable.common.R.drawable.ic_news_team_profile_ig | ||
| "FLY" -> com.teamwable.common.R.drawable.ic_news_team_profile_fly | ||
| "VKS" -> com.teamwable.common.R.drawable.ic_news_team_profile_vks | ||
| "100T" -> com.teamwable.common.R.drawable.ic_news_team_profile_100t | ||
| "CFO" -> com.teamwable.common.R.drawable.ic_news_team_profile_cfo | ||
| "TSW" -> com.teamwable.common.R.drawable.ic_news_team_profile_tsw | ||
| "PSG" -> com.teamwable.common.R.drawable.ic_news_team_profile_psg | ||
| "G2" -> com.teamwable.common.R.drawable.ic_news_team_profile_g2 | ||
| "MKOI" -> com.teamwable.common.R.drawable.ic_news_team_profile_mkoi | ||
| "FNC" -> com.teamwable.common.R.drawable.ic_news_team_profile_fnc |
There was a problem hiding this comment.
🧩 Analysis chain
해외 팀 매핑이 올바르게 추가되었습니다.
13개의 새로운 팀 매핑이 추가되어 PR 목표를 달성했습니다. 모든 참조된 드로어블 리소스가 존재하는지 확인하세요.
다음 스크립트로 모든 참조된 드로어블이 존재하는지 확인하세요:
🏁 Script executed:
#!/bin/bash
# 설명: NewsMatchScoreViewHolder에서 참조된 모든 팀 프로필 드로어블이 존재하는지 확인
echo "=== 새로 추가된 팀 드로어블 확인 ==="
for team in blg al tes ig fly vks 100t cfo tsw psg g2 mkoi fnc; do
file="core/common/src/main/res/drawable/ic_news_team_profile_${team}.xml"
if [ -f "$file" ]; then
echo "✓ $team: $file 존재"
else
echo "✗ $team: $file 없음"
fi
done
echo ""
echo "=== 기존 팀 드로어블 확인 ==="
for team in t1 gen bro drx dk kt bfx ns dnf hle; do
file="core/common/src/main/res/drawable/ic_news_team_profile_${team}.xml"
if [ -f "$file" ]; then
echo "✓ $team: $file 존재"
else
echo "✗ $team: $file 없음"
fi
doneLength of output: 1715
누락된 드로어블 리소스 추가 필요
다음 팀 프로필 리소스가 core/common/src/main/res/drawable에 없습니다:
• 새로 추가된 팀: blg, tes, ig, fly, vks, 100t, cfo, tsw, g2, fnc
• 기존 팀: bfx
해당 XML 파일을 추가하거나 매핑을 수정하세요.
🤖 Prompt for AI Agents
In
feature/news/src/main/java/com/teamwable/news/match/NewsMatchScoreViewHolder.kt
around lines 63–75, the switch/map references drawable IDs that do not exist in
core/common/src/main/res/drawable (new teams: blg, tes, ig, fly, vks, 100t, cfo,
tsw, g2, fnc and existing team bfx). Add the missing drawable XML or PNG files
to core/common/src/main/res/drawable using the exact resource names referenced
(ic_news_team_profile_blg, ic_news_team_profile_tes, ic_news_team_profile_ig,
ic_news_team_profile_fly, ic_news_team_profile_vks, ic_news_team_profile_100t,
ic_news_team_profile_cfo, ic_news_team_profile_tsw, ic_news_team_profile_g2,
ic_news_team_profile_fnc, and ic_news_team_profile_bfx) so
com.teamwable.common.R.drawable resolves, or alternatively update the mapping in
this file to point to existing drawable resource names if different naming was
intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
너무... 오랜만에 안드 하니까 다 까먹은....😢
Summary by CodeRabbit