-
Notifications
You must be signed in to change notification settings - Fork 1
[Feature/#186] : 큐레이션 기능 구현 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
098538d
5db2d39
65c4ddd
900afdb
c478789
fece009
21ca6e7
e3b4e9a
dbd060f
f89c4b3
3f076f8
7c9db23
fee7665
0dd7bed
f7a355c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.teamwable.data.mapper.toModel | ||
|
|
||
| import com.teamwable.model.news.CurationModel | ||
| import com.teamwable.network.dto.response.news.ResponseCurationInfoDto | ||
|
|
||
| internal fun ResponseCurationInfoDto.toCuration(): CurationModel = | ||
| CurationModel( | ||
| this.curationId, | ||
| this.curationLink, | ||
| this.curationTitle ?: "", | ||
| this.curationThumbnail ?: "", | ||
| this.time, | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.teamwable.model.news | ||
|
|
||
| data class CurationModel( | ||
| val curationId: Long, | ||
| val curationLink: String, | ||
| val curationTitle: String, | ||
| val curationThumbnail: String, | ||
| val time: String, | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,4 +33,5 @@ dependencies { | |
| implementation(project(":core:model")) | ||
| implementation(project(":core:datastore")) | ||
| implementation(libs.paging) | ||
| implementation(libs.androidx.annotation.experimental) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainannotation-experimental 의존성, 실제 사용 여부 점검(네트워크 모듈엔 불필요 가능성 큼) 이 모듈에서 다음 스크립트로 core/network 내 사용 여부를 빠르게 확인해 주세요: 🏁 Script executed: #!/bin/bash
rg -nP '\bandroidx\.annotation\.Experimental\b|@Experimental\b' core/network || echo "No usages in core/network"Length of output: 25 추가 검증을 위해 전체 코드베이스에서 Length of output: 68 core/network 모듈에서 검증 결과, 번들 크기 최소화와 Gradle 의존성 그래프 정리를 위해 이 라인을 삭제하세요. 🤖 Prompt for AI Agents |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.teamwable.network.dto.response.news | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class ResponseCurationInfoDto( | ||
| @SerialName("curationId") val curationId: Long, | ||
| @SerialName("curationLink") val curationLink: String, | ||
| @SerialName("curationTitle") val curationTitle: String?, | ||
| @SerialName("curationThumbnail") val curationThumbnail: String?, | ||
| @SerialName("time") val time: String, | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.teamwable.network.dto.response.news | ||
|
|
||
| import kotlinx.serialization.InternalSerializationApi | ||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @OptIn(InternalSerializationApi::class) | ||
| @Serializable | ||
| data class ResponseNewsCurationNumberDto( | ||
| @SerialName("curationId") val curationId: Long, | ||
| ) | ||
|
Comment on lines
+7
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major 🧩 Analysis chain@OptIn(InternalSerializationApi::class) 사용이 필요한지 확인해주세요. 단순한 데이터 클래스에 이 어노테이션을 제거하고도 정상적으로 직렬화가 동작하는지 확인해주세요. 일반적으로 🏁 Script executed: #!/bin/bash
# Description: Check if other DTOs in the project use @OptIn(InternalSerializationApi::class)
# Search for other DTO files to see the pattern
rg -n "@OptIn\(InternalSerializationApi" --type kotlin -C 3Length of output: 1846 추가 검증을 위해 프로젝트의 다른 DTO 파일들을 확인하여 이 어노테이션 사용 패턴을 비교하겠습니다.
이 어노테이션으로 표시된 API는 효과적으로 내부이며, kotlinx.serialization 외부에서 사용되어서는 안 되며, 호환성이 보장되지 않습니다. 단순한 데이터 클래스에서는 @serializable과 @SerialName 어노테이션만으로 충분합니다. 프로젝트의 다른 DTO 파일들을 확인하고 이 어노테이션 없이도 정상적으로 작동하는지 검증한 후 제거하시기 바랍니다. @Serializable
data class ResponseNewsCurationNumberDto(
@SerialName("curationId") val curationId: Long,
)🤖 Prompt for AI Agents |
||
Uh oh!
There was an error while loading. Please reload this page.