Guard against NPE in SmbDeviceScannerObservable #4381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4299. Also added explicit DiscoverDeviceStrategy.onCancel() call when SmbDeviceScannerObservable.stop()s.
TranceLove
requested review from
EmmanuelMess,
VishalNehra,
VishnuSanal and
Copilot
VishnuSanal
approved these changes
Apr 14, 2025
VishnuSanal
added
the
PR-Awaiting-Final-Review
EmmanuelMess
approved these changes
Apr 16, 2025
Member
EmmanuelMess
left a comment
EmmanuelMess
left a comment
There was a problem hiding this comment.
Cannot replicate original issue, but code is an improvement, so I'm approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added empty Disposable to prevent NPE when SMB search dialog cancels and re-created.
Also added explicit DiscoverDeviceStrategy.onCancel() call when SmbDeviceScannerObservable.stop()s.
Issue tracker
Fixes #4299
Manual tests
Device: Pixel 7 emulator running stock Android 14
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckRelated PR
Related to PR #4372 - may require this PR for bug-free SMB device discovery experience.