Skip to content

Fix the whitespace around filename or extension causes false negative #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmmanuelMess merged 1 commit into from
Dec 9, 2025
Merged

Fix the whitespace around filename or extension causes false negative #4482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/src/main/java/com/amaze/filemanager/filesystem/files/FileUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,8 +968,20 @@ public static boolean isRoot(

/** Convenience method to return if a path points to a compressed file. */
public static boolean isCompressedFile(String path) {
@Nullable String extension = MimeTypes.getExtension(path);
return ArraysKt.indexOf(COMPRESSED_FILE_EXTENSIONS, extension) > -1;
if (path == null) return false;

// Normalize input: trim leading/trailing whitespace first
String normalizedPath = path.trim();
if (normalizedPath.isEmpty()) return false;

// Extract extension using MimeTypes helper, then normalize it
String extension = MimeTypes.getExtension(normalizedPath);
if (!extension.isEmpty()) {
extension = extension.trim().toLowerCase(Locale.getDefault());
return ArraysKt.indexOf(COMPRESSED_FILE_EXTENSIONS, extension) > -1;
}

return false;
}

/** Converts ArrayList of HybridFileParcelable to ArrayList of File */
Expand Down
Loading