Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 97.22% 97.22% +<.01%
==========================================
Files 44 44
Lines 2813 2814 +1
Branches 535 535
==========================================
+ Hits 2735 2736 +1
Misses 41 41
Partials 37 37
|
|
Any chance this pull request will be merged? This is quite an important bug |
Contributor
|
Sorry for slow feedback @sharthZ and @gabrielelanaro , I think there are two items preventing the merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think, this will fix #248
Can't run tests, because in my version of xgboost
xgb.booster()must be replaced byxgb.get_booster()