Remove parsel dependency #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 97.82% 97.93% +0.11%
==========================================
Files 2 2
Lines 92 97 +5
Branches 17 18 +1
==========================================
+ Hits 90 95 +5
Misses 2 2
|
lopuhin
reviewed
Nov 14, 2018
lopuhin
reviewed
Nov 14, 2018
* _html_to_text is promoted to a public html_text.etree_to_text * html_text.cleaner object is exposed * parsel is imported only when needed * create_root_node implementation is copy-pasted to parse_html, to remove dependency * parsel is removed from install_requiers * README is updated The goal is to allow using html_text in parsel.
this is to cover all branches in parse_html function
kmike
force-pushed
the
remove-parsel-dependency
branch
from
603a7d9 to
2bfcf2c
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #14.
to remove dependency
Motivation: make it possible for parsel to depend on html-text for scrapy/parsel#127.