Open
Conversation
Contributor
m0ebiuz
commented
Aug 7, 2023
m0ebiuz
commented
- all alias-related
- except arbiter tribunal which simply was missing the templar archive req
- removed leftover hydralisk den alias
Member
|
I think this one is fine as it is, just sorting out how to checkout a pull request locally without gh cli |
abrahamYG
reviewed
Aug 15, 2023
Member
abrahamYG
left a comment
abrahamYG
left a comment
There was a problem hiding this comment.
Ok, so my only concern with the way alias hvae been set up is that requirement nodes can't resolve to names. I will see if there is a way to relatively automate that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.