Skip to content

fix: fix notification type, db query #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seoljiwon wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: fix notification type, db query #407

seoljiwon wants to merge 1 commit into from

Conversation

@seoljiwon
Copy link
Contributor

@seoljiwon seoljiwon commented Jan 9, 2023

  • 타입 하드코딩 되어있는 부분 변경했습니다.
  • db query에서 삭제된 post가 있는 경우 알림을 그대로 띄우지만, 삭제된 major가 있는 경우의 학과 커뮤니티 알림은 띄우지 않는 것이 맞을 것 같아 조건 추가했습니다.

@seoljiwon seoljiwon self-assigned this Jan 9, 2023
@seoljiwon seoljiwon added the fix Something isn't working label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wngus4296 wngus4296 Awaiting requested review from wngus4296

@eunji8784 eunji8784 Awaiting requested review from eunji8784

At least 1 approving review is required to merge this pull request.

Assignees

@seoljiwon seoljiwon

Labels

fix Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seoljiwon