Fix timestamps not working in comment replies#12202
Merged
Profpatsch merged 1 commit intoTeamNewPipe:devfrom May 7, 2025
Merged
Fix timestamps not working in comment replies#12202Profpatsch merged 1 commit intoTeamNewPipe:devfrom
Profpatsch merged 1 commit intoTeamNewPipe:devfrom
Conversation
ShareASmile
added
bug
app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentRepliesFragment.java
Outdated
Show resolved
Hide resolved
|
Seems surprising to me that this can be pulled out. Great job towards it!! |
Use LinkMovementMethodCompat for comment links Co-authored-by: Isira Seneviratne <31027858+Isira-Seneviratne@users.noreply.github.com> Update import Use LongPressLinkMovementMethod
Contributor
|
Tried & fixes the issue. Thanks! |
Profpatsch
approved these changes
May 7, 2025
Profpatsch
force-pushed
the
fix/timestamp-clicks-in-replies
branch
from
75d8c41 to
e7f3750
Compare
Contributor
|
I squashed the commits a little |
|
11 tasks
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Jul 27, 2025
…p-clicks-in-replies Fix timestamps not working in comment replies
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Oct 6, 2025
…p-clicks-in-replies Fix timestamps not working in comment replies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixed issue where clicking on timestamps in comment replies didn’t trigger the expected action (opening a popup with the video playing in the expected timestamp).
Before/After Screenshots/Screen Record
331957480-d5785fbd-3492-4ef6-9421-a64262cf93be.mp4
Edited_20250424_164337.mp4
Fixes the following issue(s)
Due diligence