Fix header crash in History list view

[j-haldane]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Supply header to LocalItemListAdapter with a supplier
• Changes adapted from d3cd3d6

Before/After Screenshots/Screen Record

• Before:
  
• After:
  

Fixes the following issue(s)

• Fixes Crash in lists (ViewHolder views not attached) #4475
• This could be reproduced intermittently under these conditions:
  • Open the watch history list
  • Have video player drawer open and minimized
  • Scroll down far enough in the list so the header is not visible
  • Rotate the device until the bug happens
• The header would sometimes be drawn under the list items. If a user then scrolled back up to where the header was visible this would cause a crash when the RecyclerView tried to create the attached HeaderFooterHolder.
• Testing the above steps to reproduce the bug, I couldn't get the bug to happen again after these changes were applied.

Due diligence

• I read the contribution guidelines.

[j-haldane]

After further testing I found that prior commits did fix the issue, but only because it broke an animation being applied to the header in BaseLocalListFragment. This animation was the cause of the problem. I decided to simply remove the animation instead.

This animation seems to be causing an issue with the recycling of the header. If anyone has a better solution that would allow the animation to be kept please let me know!

Personally: I can't tell the difference with or without the animation, even on a 120hz display.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Profpatsch]

I think removing this animation cannot hurt, so let’s merge (even though I can’t reproduce here, other people will have to say if that fixes it :))

[Stypox]

@j-haldane thanks a lot for this, we have tried to investigate #4475 multiple times to no avail, so it's great to see it's finally getting fixed!

[ShareASmile]

@j-haldane would you look into it again?as it hasn't fully fixed the crash, please see the comment in the linked issue.